Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support inline policies #79

Merged
merged 6 commits into from
Nov 22, 2024
Merged

feat: support inline policies #79

merged 6 commits into from
Nov 22, 2024

Conversation

nitrocode
Copy link
Member

@nitrocode nitrocode commented Nov 15, 2024 •
edited
Loading

what

  • support inline policies

why

  • Most of the time users want to create a specific policy for a specific role and don't realize that the same policy can be accidentally reused for another purpose which makes it difficult to delete the role and policy
  • Inline policies do not need to be tagged
  • If a managed policy is updated and is attached to multiple roles, now it will impact multiple roles

references

@nitrocode nitrocode requested review from a team as code owners November 15, 2024 08:22
@mergify mergify bot added the triage Needs triage label Nov 15, 2024
@nitrocode
Copy link
Member Author

/terratest

@nitrocode nitrocode changed the title feat: support Inline policies feat: support inline policies Nov 15, 2024
@nitrocode
Copy link
Member Author

/terratest

@nitrocode nitrocode enabled auto-merge (squash) November 22, 2024 10:37
milldr
milldr approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@milldr milldr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nitrocode nitrocode merged commit 0fd6a7a into main Nov 22, 2024
16 checks passed
@nitrocode nitrocode deleted the inline-policy branch November 22, 2024 15:29
@milldr milldr added minor New features that do not break anything and removed triage Needs triage labels Nov 22, 2024
@github-actions GitHub Actions
Copy link

These changes were released in v0.20.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milldr milldr milldr approved these changes

@Gowiem Gowiem Awaiting requested review from Gowiem Gowiem is a code owner automatically assigned from cloudposse/contributors

@joe-niland joe-niland Awaiting requested review from joe-niland joe-niland is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
minor New features that do not break anything
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Option to use an inline policy instead of a managed policy
2 participants
@nitrocode @milldr