Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add enabled check to data source #45

Merged
merged 13 commits into from
Apr 22, 2022
Merged

Add enabled check to data source #45

merged 13 commits into from
Apr 22, 2022

Conversation

nitrocode
Copy link
Member

@nitrocode nitrocode commented Apr 22, 2022 •
edited
Loading

what

  • Add enabled check to data source
  • Add TestExamplesCompleteDisabled check

why

  • Prevent creation if enabled is false

references

@nitrocode nitrocode added the patch A minor, backward compatible change label Apr 22, 2022
@nitrocode
Copy link
Member Author

/test all

@nitrocode
Copy link
Member Author

/test all

@nitrocode
Copy link
Member Author

/test all

@nitrocode
Copy link
Member Author

/test all

@nitrocode
Copy link
Member Author

/test all

@nitrocode
Copy link
Member Author

/test all

@nitrocode nitrocode mentioned this pull request Apr 22, 2022
Merged
5 tasks
@nitrocode
Copy link
Member Author

/test all

@nitrocode
Copy link
Member Author

/test all

@nitrocode
Copy link
Member Author

/test all

@nitrocode nitrocode marked this pull request as ready for review April 22, 2022 13:50
@nitrocode nitrocode requested review from a team as code owners April 22, 2022 13:50
@nitrocode nitrocode requested review from Gowiem and woz5999 April 22, 2022 13:50
Gowiem
Gowiem approved these changes Apr 22, 2022
View reviewed changes
Copy link
Member

@Gowiem Gowiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great test code... are we rolling that out to other modules? Seems like the right move!

@Gowiem Gowiem merged commit ea635c3 into master Apr 22, 2022
@Gowiem Gowiem deleted the enabled-check-data-source branch April 22, 2022 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gowiem Gowiem Gowiem approved these changes

@woz5999 woz5999 Awaiting requested review from woz5999 woz5999 was automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
patch A minor, backward compatible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nitrocode @Gowiem @cloudpossebot