Fix: fix variable description for var.use_fullname, run make github/init
#35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korenyoni
added
the
no-release
korenyoni
changed the title
var.use_fullnamevar.use_fullname, run make github/init
|
/test all |
osterman
approved these changes
Dec 19, 2021
korenyoni
added a commit
that referenced
this pull request
Dec 20, 2021
* Fix variable description typo introduced in #35 for `var.use_fullname` Co-authored-by: cloudpossebot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
var.use_fullname.make github/init.why
var.use_fullnamevariable description is incorrect and refers to ECR repositories instead of IAM roles.make github/initwill update GHA-workflow related files (and CODEOWNERS), the former of which is required for theno-releaselabel (which allows for consolidating multiple small PRs such as this into one release).references