Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop unused null provider #34

Merged
merged 2 commits into from
Dec 20, 2021
Merged

Drop unused null provider #34

merged 2 commits into from
Dec 20, 2021

Conversation

Xerkus
Copy link
Contributor

@Xerkus Xerkus commented Dec 8, 2021

what

  • Drop hashicorp/null provider from dependencies

why

  • As far as I can tell the null provider is not used and I do not think it is needed for any kind of indirect dependency
  • I think it was needed at some point for terraform-null-label

references

@Xerkus
Drop unused null provider
45a4899 
Signed-off-by: Aleksei Khudiakov <[email protected]>
@Xerkus Xerkus requested review from a team as code owners December 8, 2021 17:01
@Xerkus Xerkus requested a review from a team as a code owner December 8, 2021 17:01
@Xerkus Xerkus requested review from florian0410 and woz5999 December 8, 2021 17:01
@nitrocode nitrocode added the patch A minor, backward compatible change label Dec 10, 2021
nitrocode
nitrocode approved these changes Dec 10, 2021
View reviewed changes
Copy link
Member

@nitrocode nitrocode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test all

@nitrocode
Copy link
Member

/test all

1 similar comment
@korenyoni
Copy link
Member

/test all

@korenyoni korenyoni added no-release Do not create a new release (wait for additional code changes) and removed patch A minor, backward compatible change labels Dec 20, 2021
@korenyoni korenyoni merged commit 112963e into cloudposse:master Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korenyoni korenyoni korenyoni approved these changes

@nitrocode nitrocode nitrocode approved these changes

@florian0410 florian0410 Awaiting requested review from florian0410 florian0410 was automatically assigned from cloudposse/contributors

@woz5999 woz5999 Awaiting requested review from woz5999 woz5999 was automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
no-release Do not create a new release (wait for additional code changes)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Null provider is unused as direct dependency
4 participants
@Xerkus @nitrocode @korenyoni @cloudpossebot