Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark "codebuild" output as sensitive #89

Merged
merged 2 commits into from
Feb 4, 2021
Merged

Mark "codebuild" output as sensitive #89

merged 2 commits into from
Feb 4, 2021

Conversation

adamantike
Copy link
Contributor

What

Mark codebuild output as sensitive.

Why

Terraform 0.14 fails when trying to run this module, because the codebuild output is not marked as sensitive. However, codepipeline_webhook_url is correctly marked.

Error: Output refers to sensitive values

  on .terraform/modules/ecs_web_app/outputs.tf line 146:
 146: output "codebuild" {

Expressions used in outputs can only refer to sensitive values if the
sensitive attribute is true.

@adamantike
Mark codebuild output as sensitive
6b354da 
Terraform 0.14 fails when trying to run this module, because the
`codebuild` output is not marked as sensitive. However,
`codepipeline_webhook_url` is correctly marked.
@adamantike adamantike requested review from a team as code owners January 27, 2021 16:01
@adamantike adamantike requested review from Gowiem and woz5999 and removed request for a team January 27, 2021 16:01
@SweetOps
Copy link
Contributor

SweetOps commented Feb 3, 2021

/test all

@SweetOps
Copy link
Contributor

SweetOps commented Feb 3, 2021

/rebuild-readme

@adamantike adamantike requested a review from a team as a code owner February 3, 2021 15:31
@SweetOps
Copy link
Contributor

SweetOps commented Feb 3, 2021

/test all

@SweetOps SweetOps added the bug 🐛 An issue with the system label Feb 3, 2021
@SweetOps SweetOps merged commit 83640f5 into cloudposse:master Feb 4, 2021
Nuru added a commit that referenced this pull request Feb 5, 2021
@Nuru
Revert "Mark "codebuild" output as sensitive (#89)"
a66f605 
This reverts commit 83640f5.
@adamantike adamantike deleted the codebuild-sensitive branch April 26, 2021 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SweetOps SweetOps SweetOps approved these changes

@Gowiem Gowiem Awaiting requested review from Gowiem

@woz5999 woz5999 Awaiting requested review from woz5999

Assignees
No one assigned
Labels
bug 🐛 An issue with the system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adamantike @SweetOps @actions-bot