Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terraform 0.14 upgrade #81

Merged
merged 4 commits into from
Jan 25, 2021
Merged

Terraform 0.14 upgrade #81

merged 4 commits into from
Jan 25, 2021

Conversation

maximmi
Copy link
Contributor

@maximmi maximmi commented Jan 5, 2021

what

  • Upgrade to support Terraform 0.14 and bring up to current Cloud Posse standard

why

blocked by https://github.com/cloudposse/terraform-aws-ecs-codepipeline/pull/54/files

@maximmi maximmi requested a review from a team as a code owner January 5, 2021 15:55
@maximmi maximmi requested review from Makeshift and 3h4x and removed request for a team January 5, 2021 15:55
@maximmi maximmi self-assigned this Jan 5, 2021
@maximmi
Copy link
Contributor Author

maximmi commented Jan 7, 2021

/test all

@adamantike
Copy link
Contributor

@maximmi, is there anything blocking this PR from being merged?

@jhosteny
Copy link
Contributor

@maximmi, is there anything blocking this PR from being merged?

I think this is blocked by https://github.com/cloudposse/terraform-aws-ecs-codepipeline/pull/54/files, and then also needs an update on the version for the ecs_cloudwatch_autoscale module, which has been updated for 0.14 support.

osterman
osterman previously approved these changes Jan 21, 2021
@maximmi maximmi changed the title Terraform 0.14 upgrade [WIP] Terraform 0.14 upgrade Jan 22, 2021
osterman
osterman previously approved these changes Jan 22, 2021
@maximmi
Copy link
Contributor Author

maximmi commented Jan 23, 2021

/test all

@maximmi
Copy link
Contributor Author

maximmi commented Jan 25, 2021

/test all

@jross-ai
Copy link
Contributor

Is there an ETA for when this is going to get merged in?

@maximmi maximmi changed the title [WIP] Terraform 0.14 upgrade Terraform 0.14 upgrade Jan 25, 2021
@maximmi maximmi merged commit 8731431 into master Jan 25, 2021
@maximmi maximmi deleted the terraform-0.14-upgrade branch January 25, 2021 16:46
@maximmi
Copy link
Contributor Author

maximmi commented Jan 25, 2021

@adamantike @jhosteny @jross-ai here is new release: https://github.com/cloudposse/terraform-aws-ecs-web-app/releases/tag/0.48.0

thank you all for contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants