Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies that we can use this module with aws provider 3.x #78

Merged
merged 10 commits into from
Dec 3, 2020
Merged

Update dependencies that we can use this module with aws provider 3.x #78

merged 10 commits into from
Dec 3, 2020

Conversation

dmitrijn
Copy link
Contributor

what

  • Update module dependencies for aws provider 3.x

why

references

@joe-niland
Copy link
Member

/test all

@joe-niland joe-niland self-requested a review November 30, 2020 00:00
@joe-niland joe-niland self-assigned this Nov 30, 2020
@joe-niland
Copy link
Member

/rebuild-readme

@joe-niland
Copy link
Member

Hi @dmitrijn can you please run make readme?

@joe-niland
Copy link
Member

/test all

@jamengual
Copy link
Contributor

/test all

@dmitrijn
Copy link
Contributor Author

@joe-niland @jamengual can you run tests one more time?

@joe-niland
Copy link
Member

/test all

@dmitrijn
Copy link
Contributor Author

dmitrijn commented Dec 2, 2020 •
edited
Loading

@joe-niland @jamengual could you suggest what to do with failed tests? as i see depended modules supports context and adds attributes in end of string, not that is expected by tests. what we can do? could you help?

@joe-niland
Copy link
Member

joe-niland commented Dec 2, 2020 •
edited
Loading

@dmitrijn I haven't had a chance to look in detail but it looks like the issue is the labelling of the cloudwatch alarms.

The order of attributes added at the end of the label id has changed.

Will try to look at this a bit later.

https://github.com/cloudposse/actions/runs/1477087502?check_suite_focus=true

@joe-niland
Copy link
Member

/test all

@joe-niland
Copy link
Member

/test terratest

@dmitrijn
Copy link
Contributor Author

dmitrijn commented Dec 3, 2020

@joe-niland could you rerun terratest?

@joe-niland
Copy link
Member

/test terratest

@dmitrijn
Copy link
Contributor Author

dmitrijn commented Dec 3, 2020

@joe-niland pls, rerun tests one more time 🙂

@joe-niland
Copy link
Member

/test all

@dmitrijn
Copy link
Contributor Author

dmitrijn commented Dec 3, 2020

@joe-niland hurrah 🙂 looks like all is fine now

joe-niland
joe-niland reviewed Dec 3, 2020
View reviewed changes
variables.tf Outdated Show resolved Hide resolved
@joe-niland
Copy link
Member

/test all

@joe-niland
Copy link
Member

/test terratest

@joe-niland joe-niland merged commit 8c5e9fd into cloudposse:master Dec 3, 2020
@joe-niland
Copy link
Member

joe-niland commented Dec 3, 2020 •
edited
Loading

Merged @dmitrijn.
Thanks for your work and your patience! 🙂

@joe-niland joe-niland mentioned this pull request Dec 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe-niland joe-niland joe-niland approved these changes

Assignees

@joe-niland joe-niland

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dmitrijn @joe-niland @jamengual @paybis-admin