Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loosen the AWS provider requirement #77

Merged
merged 5 commits into from
Nov 17, 2020
Merged

Loosen the AWS provider requirement #77

merged 5 commits into from
Nov 17, 2020

Conversation

okgolove
Copy link
Contributor

what

  • Update aws provider version requirements

why

  • 3.0 AWS provider is already here and we should be able to use the module with it

@osterman
Copy link
Member

/test all

@osterman osterman requested a review from aknysh November 16, 2020 17:44
jamengual
jamengual reviewed Nov 16, 2020
View reviewed changes
versions.tf Outdated Show resolved Hide resolved
@joe-niland
Copy link
Member

@aknysh @jamengual do you think we should use lower bound pinning on the null, template and local providers also ?

@aknysh
Copy link
Member

aknysh commented Nov 16, 2020

@aknysh @jamengual do you think we should use lower bound pinning on the null, template and local providers also ?

we do it everywhere, and out tests check for all provider pinning, so I'd say let's continue doing it

aknysh
aknysh reviewed Nov 16, 2020
View reviewed changes
versions.tf Outdated Show resolved Hide resolved
aknysh
aknysh reviewed Nov 16, 2020
View reviewed changes
versions.tf Outdated Show resolved Hide resolved
aknysh
aknysh reviewed Nov 16, 2020
View reviewed changes
versions.tf Outdated Show resolved Hide resolved
@okgolove @aknysh
Use gte for all providers
26e2275 
Co-authored-by: Andriy Knysh <[email protected]>
@okgolove
Copy link
Contributor Author

@aknysh fixed!

@aknysh
Copy link
Member

aknysh commented Nov 17, 2020

@okgolove thanks
sorry, forgot to mention it, but please do the same changes in all of the examples
https://github.com/cloudposse/terraform-aws-ecs-web-app/blob/master/examples/complete/versions.tf
https://github.com/cloudposse/terraform-aws-ecs-web-app/blob/master/examples/with_cognito_authentication/versions.tf
https://github.com/cloudposse/terraform-aws-ecs-web-app/blob/master/examples/with_google_oidc_authentication/versions.tf
https://github.com/cloudposse/terraform-aws-ecs-web-app/blob/master/examples/without_authentication/versions.tf

@aknysh aknysh closed this Nov 17, 2020
@aknysh aknysh reopened this Nov 17, 2020
@okgolove
Copy link
Contributor Author

@aknysh done.

@aknysh
Copy link
Member

aknysh commented Nov 17, 2020

/test all

@aknysh
Copy link
Member

aknysh commented Nov 17, 2020

/rebuild-readme

@aknysh
Copy link
Member

aknysh commented Nov 17, 2020

/test all

@aknysh aknysh merged commit 5e4ab35 into cloudposse:master Nov 17, 2020
@okgolove okgolove deleted the aws-provider-version branch November 18, 2020 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamengual jamengual jamengual left review comments

@aknysh aknysh aknysh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@okgolove @osterman @joe-niland @aknysh @jamengual @actions-bot