Map environment #62
Merged
Map environment #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/rebuild-readme |
|
/test all |
aknysh
reviewed
Jul 28, 2020
Co-authored-by: Andriy Knysh <[email protected]>
|
/rebuild-readme |
|
/test all |
|
@aknysh I used the same variable description as the upstream module. We might want to change it upstream too. I merged your changes, rebuilt the readme, and reran the tests. Looks good! Mind taking another look? |
osterman
approved these changes
Jul 30, 2020
|
ah yes, too bad on the inconsistent naming. Do we have a consistent naming document we can refer to ? Might also help to add this document as a checkbox on new PRs within the PR template |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
map_environmentargument of the container definition module to make the environment variables more readablewhy
references