Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Expose underlying service task module's ignore_changes_desired_count #180

Merged
merged 2 commits into from
Jan 21, 2022
Merged

feat: Expose underlying service task module's ignore_changes_desired_count #180

merged 2 commits into from
Jan 21, 2022

Conversation

tpickett66
Copy link
Contributor

what

  • This exposes the ignore_changes_desire_count flag from terraform-aws-ecs-alb-service-task

why

  • When a service has scaled up the desired count will be changed by the Autoscaling process but applying this module will attempt to revert that change, this can cause service disruptions in services that have scaled up significantly.

references

@tpickett66 tpickett66 requested review from a team as code owners January 20, 2022 20:13
@tpickett66 tpickett66 requested a review from a team as a code owner January 20, 2022 20:14
@aknysh
Copy link
Member

aknysh commented Jan 21, 2022

/test all

aknysh
aknysh approved these changes Jan 21, 2022
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @tpickett66

@aknysh aknysh added the patch A minor, backward compatible change label Jan 21, 2022
@aknysh aknysh merged commit be3242c into cloudposse:master Jan 21, 2022
@tpickett66 tpickett66 deleted the ignore-desired-count branch January 31, 2022 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh approved these changes

@srhopkins srhopkins Awaiting requested review from srhopkins srhopkins was automatically assigned from cloudposse/contributors

@woz5999 woz5999 Awaiting requested review from woz5999 woz5999 was automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
patch A minor, backward compatible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tpickett66 @aknysh @cloudpossebot