Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added few variables to enable HealthCheck configuration of the ALB #160

Merged
merged 3 commits into from
Aug 18, 2021

Conversation

idestis
Copy link
Contributor

@idestis idestis commented Aug 13, 2021

what

  • Proxied 4 variables to cloudposse/alb-ingress/aws to manage ALB HealthCheck configuration

why

  • Task health check is one way to validate that container is up and running, but as well we should have an ability to change ALB health check options

@idestis idestis requested review from a team as code owners August 13, 2021 22:34
@idestis idestis requested review from bradj and dylanbannon August 13, 2021 22:34
@nitrocode
Copy link
Member

/test all

@nitrocode
Copy link
Member

/test all

type = number
default = 10
description = "The amount of time to wait in seconds before failing a health check request"
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that these are the same defaults in the upstream module

https://github.com/cloudposse/terraform-aws-alb-ingress

@nitrocode nitrocode merged commit 24b941e into cloudposse:master Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants