Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable setting custom task policy/role #155

Merged
merged 4 commits into from
Jul 22, 2021
Merged

Enable setting custom task policy/role #155

merged 4 commits into from
Jul 22, 2021

Conversation

kevcube
Copy link
Contributor

@kevcube kevcube commented Jul 20, 2021

what

  • We needed to give our container IAM permissions to perform AWS tasks.

why

  • We're deploying an internal app that needed to be able to operate on S3 files.
  • We needed to be able to give the container permissions to call S3.

@kevcube kevcube requested review from a team as code owners July 20, 2021 21:24
@Gowiem
Copy link
Member

Gowiem commented Jul 21, 2021

@kevcube since you PR'd this from an org fork, please run the following locally, commit, and push:

make init
make readme

@Gowiem
Copy link
Member

Gowiem commented Jul 21, 2021

/test all

@kevcube kevcube requested a review from a team as a code owner July 21, 2021 20:15
@kevcube kevcube requested review from srhopkins and woz5999 July 21, 2021 20:15
@Gowiem
Copy link
Member

Gowiem commented Jul 21, 2021

/test all

@Gowiem
Copy link
Member

Gowiem commented Jul 22, 2021

/test all

@Gowiem Gowiem merged commit 68b4a99 into cloudposse:master Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gowiem Gowiem Gowiem approved these changes

@srhopkins srhopkins Awaiting requested review from srhopkins

@woz5999 woz5999 Awaiting requested review from woz5999

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevcube @Gowiem