Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Usage of the repository_credentials #142

Merged
merged 15 commits into from
Apr 22, 2021
Merged

Add Usage of the repository_credentials #142

merged 15 commits into from
Apr 22, 2021

Conversation

maeghan-porter
Copy link
Contributor

what

  • Add the usage of the repository_credentials variable offered by the task definition module.

why

  • There are cases when one may be using a private repository to store their images and need to pass repository credentials to the task definition. The task definition module provides this variable so I am updating this module to utilize it.

@maeghan-porter maeghan-porter requested review from a team as code owners April 22, 2021 20:07
@jamengual
Copy link
Contributor

/test all

jamengual
jamengual previously approved these changes Apr 22, 2021
View reviewed changes
@jamengual
Copy link
Contributor

/test all

@jamengual
Copy link
Contributor

/test all

@jamengual
Copy link
Contributor

/test all

@jamengual
Copy link
Contributor

/test all

@jamengual jamengual merged commit 44b689b into cloudposse:master Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamengual jamengual jamengual approved these changes

@adamcrews adamcrews Awaiting requested review from adamcrews

@nitrocode nitrocode Awaiting requested review from nitrocode

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maeghan-porter @jamengual @cloudpossebot