-
-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update terraform cloudposse/ecs-container-definition/aws to v0.55.0 #134
chore(deps): update terraform cloudposse/ecs-container-definition/aws to v0.55.0 #134
Conversation
/test all |
@nitrocode Looks like this module needs to be updated to work with the changes in cloudposse/ecs-container-definition/aws . I have not looked into the details, but if possible, it would be better to update cloudposse/ecs-container-definition/aws so that it remains backwards compatible. Example error from test:
|
61dc125
to
fbe14dd
Compare
I changed the default of Edit: on second thought, might be better to just have better conditional logic in the ecs container definition module. |
/test all |
/test all |
Seems like we have a nat gateway failure which is not relevant to this upgrade. |
/test terratest |
/test test/terratest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've automatically approved this PR because the checks from the automated Pull Request have passed.
This PR contains the following updates:
0.49.2
->0.53.0
Release Notes
cloudposse/terraform-aws-ecs-container-definition
v0.53.0
Compare Source
add sensitive variants of outputs @syphernl (#124)
##### what * Add additional outputs which are marked sensitive which can be used when passing on secrets (`secrets`) or secret maps (`map_secrets`). ##### why * When using `secrets` (or `map_secrets`) and without sensitive outputs TF 0.14 will fail with `Error: Output refers to sensitive values` ##### references * Suggestion to implement it this way was done in https://github.com/cloudposse/terraform-aws-ecs-container-definition/pull/118#issuecomment-785060412v0.52.0
Compare Source
secrets valueFrom @nitrocode (#126)
#### what * Fixes an issue in a previous PR https://github.com/cloudposse/terraform-aws-ecs-container-definition/pull/123 where `value` was used instead of `valueFrom` for the `secrets` key #### why * This fixes a bug in which the `secrets` key will break the module due to the incorrect key #### references * Closes https://github.com/cloudposse/terraform-aws-ecs-container-definition/issues/125v0.51.0
Compare Source
feat: add map_secrets @davidvasandani (#120) @nitrocode (#123)
Merge copy of #120
Commit history is the same
The original PR was failing on null secrets so I set
var.secrets
to[]
which is the same default asvar.environment
.v0.50.0
Compare Source
Remove sensitive outputs @nitrocode (#122)
#### what Revert `sensitive = true` outputs #### why Cannot see the difference in task definitions in `terraform plan` due to `sensitive = true` #### references Revert https://github.com/cloudposse/terraform-aws-ecs-container-definition/pull/118Renovate configuration
📅 Schedule: At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻️ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by WhiteSource Renovate. View repository job log here.