Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update terraform cloudposse/ecs-container-definition/aws to v0.55.0 #134

Merged
merged 6 commits into from
Mar 19, 2021

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 17, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Type Update Change
cloudposse/ecs-container-definition/aws (source) terraform minor 0.49.2 -> 0.53.0

Release Notes

cloudposse/terraform-aws-ecs-container-definition

v0.53.0

Compare Source

add sensitive variants of outputs @​syphernl (#​124) ##### what * Add additional outputs which are marked sensitive which can be used when passing on secrets (`secrets`) or secret maps (`map_secrets`). ##### why * When using `secrets` (or `map_secrets`) and without sensitive outputs TF 0.14 will fail with `Error: Output refers to sensitive values` ##### references * Suggestion to implement it this way was done in https://github.com/cloudposse/terraform-aws-ecs-container-definition/pull/118#issuecomment-785060412

v0.52.0

Compare Source

secrets valueFrom @​nitrocode (#​126) #### what * Fixes an issue in a previous PR https://github.com/cloudposse/terraform-aws-ecs-container-definition/pull/123 where `value` was used instead of `valueFrom` for the `secrets` key #### why * This fixes a bug in which the `secrets` key will break the module due to the incorrect key #### references * Closes https://github.com/cloudposse/terraform-aws-ecs-container-definition/issues/125

v0.51.0

Compare Source

feat: add map_secrets @​davidvasandani (#​120) @​nitrocode (#​123)

Merge copy of #​120

Commit history is the same

The original PR was failing on null secrets so I set var.secrets to [] which is the same default as var.environment.

v0.50.0

Compare Source

Remove sensitive outputs @​nitrocode (#​122) #### what Revert `sensitive = true` outputs #### why Cannot see the difference in task definitions in `terraform plan` due to `sensitive = true` #### references Revert https://github.com/cloudposse/terraform-aws-ecs-container-definition/pull/118

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot requested review from a team as code owners March 17, 2021 23:49
@renovate renovate bot added the auto-update This PR was automatically generated label Mar 17, 2021
@renovate renovate bot requested a review from a team as a code owner March 17, 2021 23:50
@renovate renovate bot requested review from jamengual and woz5999 March 17, 2021 23:50
@nitrocode
Copy link
Member

/test all

@Nuru
Copy link
Contributor

Nuru commented Mar 18, 2021

@nitrocode Looks like this module needs to be updated to work with the changes in cloudposse/ecs-container-definition/aws . I have not looked into the details, but if possible, it would be better to update cloudposse/ecs-container-definition/aws so that it remains backwards compatible.

Example error from test:

Error: Iteration over null value

  on .terraform/modules/ecs_web_app.container_definition/main.tf line 20, in locals:
  20:   secrets_values      = var.map_secrets != null ? values(var.map_secrets) : [for m in local.secrets_vars : lookup(m, "valueFrom")]
    |----------------
    | local.secrets_vars is null

A null value cannot be used as the collection in a 'for' expression.

@renovate renovate bot force-pushed the renovate/cloudposse-ecs-container-definition-aws-0.x branch from 61dc125 to fbe14dd Compare March 18, 2021 12:23
@nitrocode
Copy link
Member

nitrocode commented Mar 18, 2021

I changed the default of var.secrets changed from null to [] so it would be 1:1 with var.environment in cloudposse/terraform-aws-ecs-container-definition#123. I think it would be better to apply the same consistency in this repo.

Edit: on second thought, might be better to just have better conditional logic in the ecs container definition module.

@nitrocode nitrocode changed the title chore(deps): update terraform cloudposse/ecs-container-definition/aws to v0.53.0 chore(deps): update terraform cloudposse/ecs-container-definition/aws to v0.54.0 Mar 18, 2021
@nitrocode
Copy link
Member

/test all

@nitrocode nitrocode changed the title chore(deps): update terraform cloudposse/ecs-container-definition/aws to v0.54.0 chore(deps): update terraform cloudposse/ecs-container-definition/aws to v0.55.0 Mar 18, 2021
@nitrocode
Copy link
Member

/test all

@nitrocode
Copy link
Member

Seems like we have a nat gateway failure which is not relevant to this upgrade.

@nitrocode
Copy link
Member

/test terratest

@nitrocode
Copy link
Member

/test test/terratest

Copy link

@cloudposse-mergebot cloudposse-mergebot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've automatically approved this PR because the checks from the automated Pull Request have passed.

@mergify mergify bot merged commit 1b58c8c into master Mar 19, 2021
@mergify mergify bot deleted the renovate/cloudposse-ecs-container-definition-aws-0.x branch March 19, 2021 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-update This PR was automatically generated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants