Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fewer required variables #127

Merged
merged 6 commits into from
Mar 2, 2021
Merged

Fewer required variables #127

merged 6 commits into from
Mar 2, 2021

Conversation

nitrocode
Copy link
Member

what

  • Added 3 variable defaults. The ecs cluster name is only required if codepipeline is enabled.
  • The region variables don't need to be specified when the current aws region could be provided as a default

why

  • Simplifies usage of the module

references

N/A

@nitrocode nitrocode requested review from a team as code owners February 26, 2021 04:53
@nitrocode nitrocode requested a review from a team as a code owner February 26, 2021 05:04
@nitrocode
Copy link
Member Author

/test all

osterman
osterman previously approved these changes Mar 2, 2021
View reviewed changes
@nitrocode
Copy link
Member Author

/test all

@mergify mergify bot dismissed osterman’s stale review March 2, 2021 18:16

This Pull Request has been updated, so we're dismissing all reviews.

@nitrocode nitrocode merged commit 42dbebc into master Mar 2, 2021
@nitrocode nitrocode deleted the sane_defaults branch March 2, 2021 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osterman osterman osterman approved these changes

@jamengual jamengual Awaiting requested review from jamengual

@SweetOps SweetOps Awaiting requested review from SweetOps

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nitrocode @osterman @cloudpossebot