Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ecr image tag mutability variable for the ecr module #120

Merged
merged 4 commits into from
Feb 11, 2021

Conversation

jross-ai
Copy link
Contributor

@jross-ai jross-ai commented Feb 9, 2021

what

  • Add ecr_image_tag_mutability as variable to pass into the ecr module as the image_tag_mutability variable

why

  • Allow users to specify whether the ecr image tag should be mutable or immutable rather than relying on the default of immutable that is set in the ecr module

references

@jross-ai jross-ai requested review from a team as code owners February 9, 2021 16:28
@jross-ai jross-ai requested a review from a team as a code owner February 9, 2021 16:29
@Gowiem
Copy link
Member

Gowiem commented Feb 9, 2021

/test all

@jross-ai
Copy link
Contributor Author

Is there an ETA for when this will be merged in?

@jross-ai
Copy link
Contributor Author

Is there an ETA for when this will be merged in?

Following up here. Thanks for reviewing! Hoping to get this merged in soon :)

@Nuru Nuru added the patch A minor, backward compatible change label Feb 11, 2021
@Nuru Nuru merged commit db0b863 into cloudposse:master Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch A minor, backward compatible change
Projects
None yet
8 participants