Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add sensitive variants of outputs #124

Merged
merged 4 commits into from
Mar 8, 2021
Merged

add sensitive variants of outputs #124

merged 4 commits into from
Mar 8, 2021

Conversation

syphernl
Copy link
Contributor

@syphernl syphernl commented Mar 2, 2021 •
edited
Loading

what

  • Add additional outputs which are marked sensitive which can be used when passing on secrets (secrets) or secret maps (map_secrets).

why

  • When using secrets (or map_secrets) and without sensitive outputs TF 0.14 will fail with Error: Output refers to sensitive values

references

@syphernl syphernl requested review from a team as code owners March 2, 2021 09:08
@syphernl syphernl requested review from 3h4x and joe-niland March 2, 2021 09:08
@mergify
Copy link

mergify bot commented Mar 2, 2021

This pull request is now in conflict. Could you fix it @syphernl? 🙏

@nitrocode
Copy link
Member

/test all

@nitrocode
Copy link
Member

/test all

@Gowiem Gowiem merged commit 41cb05d into cloudposse:master Mar 8, 2021
@syphernl syphernl deleted the fix/sensitive_secrets branch March 8, 2021 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitrocode nitrocode nitrocode approved these changes

@jamengual jamengual jamengual approved these changes

@3h4x 3h4x Awaiting requested review from 3h4x

@joe-niland joe-niland Awaiting requested review from joe-niland

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@syphernl @nitrocode @jamengual @Gowiem