prevent github OAuthToken from causing unwanted changes #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dknell
requested review from
nitrocode and
SweetOps
and removed request for
a team
|
/test all |
|
/rebuild-readme |
|
/test all |
joe-niland
approved these changes
Sep 12, 2020
|
Thanks @dknell ! |
|
Thanks @joe-niland ! Curious if your modules that depend on this (like ecs-web-app) automatically update dependencies or do I need to submit a PR for that too? |
|
@dknell good question! At the moment it's manual, but others are looking into dependabot or similar. If you have time, another PR on dependent modules would be great. If not, I think I could do ecs-web-app tomorrow. |
|
on it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
why
aws_codepipelineresource doesn't save the token in the state file. This causes it to detect changes on every apply, regardless of a change in the terraform files.references