Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating deprecated docker image #130

Merged
merged 3 commits into from
May 22, 2024
Merged

updating deprecated docker image #130

merged 3 commits into from
May 22, 2024

Conversation

Roondel
Copy link
Contributor

@Roondel Roondel commented Apr 6, 2024

what

updating the default docker image as it is deprecated.
https://docs.aws.amazon.com/codebuild/latest/userguide/build-env-ref-available.html

why

Module was throwing an error for privileged mode invalid input even when the tfvars is passing in a valid boolean.
│ Error: creating CodeBuild project: InvalidInputException: PrivilegedMode has to be set for projects with AWS CodeBuild Docker curated images.

│ with module.ecs-codepipeline.module.codebuild.aws_codebuild_project.default[0],
│ on .terraform\modules\ecs-codepipeline.codebuild\main.tf line 356, in resource "aws_codebuild_project" "default":
│ 356: resource "aws_codebuild_project" "default" {

This has been tested locally and updated image no longer throws the error.

@Roondel Roondel requested review from a team as code owners April 6, 2024 15:35
@Roondel Roondel requested review from jamengual and joe-niland April 6, 2024 15:35
@mergify mergify bot added the triage Needs triage label Apr 6, 2024
@joe-niland joe-niland added the no-release Do not create a new release (wait for additional code changes) label May 22, 2024
@joe-niland
Copy link
Member

/terratest

@joe-niland
Copy link
Member

/terratest

@mergify mergify bot removed the triage Needs triage label May 22, 2024
@joe-niland joe-niland merged commit f61993a into cloudposse:main May 22, 2024
21 checks passed
@joe-niland
Copy link
Member

Thanks for your contribution @Roondel !

Copy link

github-actions bot commented Jul 3, 2024

These changes were released in v0.34.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-release Do not create a new release (wait for additional code changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants