Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping AWS provider version to ~> 3.0.0 #98

Closed
wants to merge 1 commit into from

Conversation

danjbh
Copy link

@danjbh danjbh commented Aug 27, 2020

what

  • Bumping our AWS provider to version 3
  • Bumping terraform-aws-vpc version to latest in examples

why

  • Allows us to take advantage of some newer Terraform features when deploying EKS
  • We need this to be in line with terraform-aws-eks-node-group, which will provide us with the ability to specify custom launch templates via aws_eks_node_group (for custom EC2 tagging)

@danjbh danjbh marked this pull request as ready for review August 27, 2020 14:35
@danjbh danjbh requested a review from a team as a code owner August 27, 2020 14:35
@danjbh danjbh requested review from jamengual and htplbc and removed request for a team August 27, 2020 14:35
@danjbh
Copy link
Author

danjbh commented Aug 27, 2020

/test all

@danjbh
Copy link
Author

danjbh commented Aug 27, 2020

We're going to include this work in a different PR so I'm going to close for now.

@danjbh danjbh closed this Aug 27, 2020
@danjbh danjbh deleted the update-aws-provider-version branch August 27, 2020 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant