Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update testing framework #157

Merged
merged 2 commits into from
Apr 28, 2022
Merged

Update testing framework #157

merged 2 commits into from
Apr 28, 2022

Conversation

Nuru
Copy link
Contributor

@Nuru Nuru commented Apr 28, 2022

what

  • Update testing framework
  • Fix and enable incomplete "existing IPs" test
  • Update git.io -> cloudposse.tools

why

  • Bring up to current standard
  • Better test coverage
  • EOL for git.io

@Nuru Nuru requested review from a team as code owners April 28, 2022 18:27
@Nuru Nuru requested review from dylanbannon and SweetOps April 28, 2022 18:27
@Nuru Nuru added the major Breaking changes (or first stable release) label Apr 28, 2022
@Nuru
Copy link
Contributor Author

Nuru commented Apr 28, 2022

/test all

@Nuru Nuru requested review from goruha, mcalhoun and nitrocode April 28, 2022 18:36
@Nuru Nuru merged commit 986386c into master Apr 28, 2022
@Nuru Nuru deleted the framework-update branch April 28, 2022 23:35
@Nuru Nuru mentioned this pull request May 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitrocode nitrocode nitrocode approved these changes

@dylanbannon dylanbannon Awaiting requested review from dylanbannon dylanbannon was automatically assigned from cloudposse/contributors

@SweetOps SweetOps Awaiting requested review from SweetOps SweetOps was automatically assigned from cloudposse/contributors

@goruha goruha Awaiting requested review from goruha

@mcalhoun mcalhoun Awaiting requested review from mcalhoun

Assignees
No one assigned
Labels
major Breaking changes (or first stable release)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nuru @nitrocode @cloudpossebot