Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bc compliance #113

Merged
merged 2 commits into from
Jan 26, 2021
Merged

Bc compliance #113

merged 2 commits into from
Jan 26, 2021

Conversation

maximmi
Copy link
Contributor

@maximmi maximmi commented Jan 19, 2021 •
edited
Loading

what

  • BridgeCrew compliance checks fix
  • readme updated
  • code clean up
  • workflows updated
  • default behaviour changed: Instance Metadata Service Version 2 forced by default
  • default behaviour changed: Encryption of the root block device enabled by default

why

  • To be able to position our modules as standards compliant
  • Providing explicit note about policy attached directly to user
  • removed unnecessary providers dependencies
  • to stay in sync with all repos
  • To comply BridgeCrew check
  • To comply BridgeCrew check

references

@maximmi maximmi requested a review from osterman January 19, 2021 09:32
@maximmi maximmi requested review from a team as code owners January 19, 2021 09:32
@maximmi maximmi requested review from joe-niland and removed request for a team January 19, 2021 09:32
@maximmi
Copy link
Contributor Author

maximmi commented Jan 19, 2021

/test all

@maximmi maximmi merged commit 886a164 into master Jan 26, 2021
@maximmi maximmi deleted the bc-compliance branch January 26, 2021 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SweetOps SweetOps SweetOps approved these changes

@osterman osterman osterman approved these changes

@joe-niland joe-niland Awaiting requested review from joe-niland

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maximmi @osterman @SweetOps