Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Would be nice if we can provide our own elasticIP while creating nat gateway. #42

Closed
rverma-nikiai opened this issue Feb 15, 2019 · 1 comment · Fixed by #86
Closed

Would be nice if we can provide our own elasticIP while creating nat gateway. #42

rverma-nikiai opened this issue Feb 15, 2019 · 1 comment · Fixed by #86

Comments

@rverma-nikiai
Copy link

Would be nice if we can provide our own elasticIP while creating a nat gateway. Since elastic IPs are very valuable for some organizations, losing them is difficult (whitelisting issues).
We completely stopped managing elasticIP through any automation tools since it leads to accidental releases. Would be nice if the same can be achieved here.
@osterman
Copy link
Member

We would accept PR :-)

@etwillbefine etwillbefine mentioned this issue Mar 21, 2020
Merged
jamengual pushed a commit that referenced this issue Jul 18, 2020
@etwillbefine
support using existing elastic ips (#86)
7dff4e6 
* support using existing elastic ips
closes #42

* add test content to main.tf and enable nat gateway

* use custom test file for existing-ips example

* use existing eips feature for NAT gateway and instance

* add nat instance ips to nat_ips output

* correct reference to existing_nat_ips

* use separate count variable for eip resources

* update README

* rebase and update docs again

* terraform fmt, address missing conflict

* remove duplicate local declaration

* remove duplicate import of eips

* correct README template after rebase
during rebase wrong side was accepted to resolve a conflict in 9cf2a85

* remove unrelated description part
nat_gateway_public_ips represent public ec2 ip addresses
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

support using existing elastic ips
2 participants
@osterman @rverma-nikiai