Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[account-map] Backwards compatibility for terraform profile users and eks/cluster #731

Merged
merged 2 commits into from
Jun 22, 2023
Merged

[account-map] Backwards compatibility for terraform profile users and eks/cluster #731

merged 2 commits into from
Jun 22, 2023

Conversation

Nuru
Copy link
Contributor

@Nuru Nuru commented Jun 21, 2023 •
edited
Loading

what

  • [account-map/modules/iam-roles] Add profiles_enabled input to override global value
  • [eks/cluster] Use iam-roles profiles_enabled input to force getting a role ARN even when profiles are in use
  • [guardduty] Make providers compatible with static and dynamic TF roles

why

  • Previously, when the global account-map profiles_enabled flag was true, iam_roles.terraform_role_arn would be null. However, eks/cluster requires terraform_role_arn regardless.
  • Changes made in refactor securityhub component #728 work in environments that have not adopted dynamic Terraform roles but would fail in environments that have (when using SuperAdmin)

@Nuru Nuru requested review from a team as code owners June 21, 2023 22:49
@Nuru Nuru requested a review from mcalhoun June 21, 2023 22:49
@Nuru Nuru requested review from aknysh, milldr and Benbentwo June 22, 2023 19:47
@Nuru Nuru changed the title [guardduty] Make providers compatible with static and dynamic TF roles [account-map] Backwards compatibility for terraform profile users and eks/cluster Jun 22, 2023
@Nuru Nuru merged commit 8d61dbe into main Jun 22, 2023
@Nuru Nuru deleted the guard-duty-providers branch June 22, 2023 21:06
goruha pushed a commit to cloudposse-terraform-components/aws-account-map that referenced this pull request Nov 27, 2024
@Nuru
[account-map] Backwards compatibility for terraform profile users and…
9daa4ac 
… eks/cluster (cloudposse/terraform-aws-components#731)
goruha pushed a commit to cloudposse-terraform-components/aws-eks-cluster that referenced this pull request Nov 27, 2024
@Nuru
[account-map] Backwards compatibility for terraform profile users and…
4bba9e0 
… eks/cluster (cloudposse/terraform-aws-components#731)
goruha pushed a commit to cloudposse-terraform-components/aws-guardduty that referenced this pull request Nov 27, 2024
@Nuru
[account-map] Backwards compatibility for terraform profile users and…
88178c6 
… eks/cluster (cloudposse/terraform-aws-components#731)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milldr milldr milldr approved these changes

@mcalhoun mcalhoun Awaiting requested review from mcalhoun

@aknysh aknysh Awaiting requested review from aknysh

@Benbentwo Benbentwo Awaiting requested review from Benbentwo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nuru @milldr