Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combined securityhub/common and securityhub/root components into single securityhub component #709

Closed
wants to merge 15 commits into from
Closed

Combined securityhub/common and securityhub/root components into single securityhub component #709

wants to merge 15 commits into from

Conversation

zdmytriv
Copy link
Contributor

@zdmytriv zdmytriv commented Jun 4, 2023

what

  • Combined securityhub/common and securityhub/root components into single securityhub component

why

  • It supposes to make it easier to maintain and use as single component

references

@zdmytriv zdmytriv requested review from a team as code owners June 4, 2023 11:33
@zdmytriv zdmytriv changed the title Combined securityhub/common and securityhub/root components into single securityhub component Combined securityhub/common and securityhub/root components into single securityhub component Jun 4, 2023
aknysh
aknysh reviewed Jun 4, 2023
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see comment

Nuru
Nuru requested changes Jun 4, 2023
View reviewed changes
modules/securityhub/README.md Outdated Show resolved Hide resolved
modules/securityhub/main.tf Outdated Show resolved Hide resolved
modules/securityhub/providers.tf Show resolved Hide resolved
@zdmytriv zdmytriv force-pushed the securityhub-combined-common-and-root-components branch from 2c5ddb9 to 0ce962c Compare June 6, 2023 12:31
Nuru
Nuru requested changes Jun 6, 2023
View reviewed changes
modules/securityhub/README.md Outdated Show resolved Hide resolved
modules/securityhub/variables.tf Outdated Show resolved Hide resolved
@zdmytriv zdmytriv requested review from Nuru and aknysh June 7, 2023 20:43
@milldr
Copy link
Member

milldr commented Nov 21, 2023

done by #728

@milldr milldr closed this Nov 21, 2023
@goruha goruha deleted the securityhub-combined-common-and-root-components branch November 1, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nuru Nuru Awaiting requested review from Nuru

@aknysh aknysh Awaiting requested review from aknysh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zdmytriv @milldr @Nuru @aknysh @mcalhoun