Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Admonition Style #1092

Merged
merged 8 commits into from
Aug 7, 2024
Merged

Replace Admonition Style #1092

merged 8 commits into from
Aug 7, 2024

Conversation

milldr
Copy link
Member

@milldr milldr commented Aug 6, 2024 •
edited
Loading

what

  • Replace all Docusarus style admonitions with GitHub style admonitions

why

  • We now can provide the GH style here and have the docs site convert the format into Docusarus style

references

@milldr milldr added no-release Do not create a new release (wait for additional code changes) documentation Improvements or additions to documentation labels Aug 7, 2024
@milldr milldr marked this pull request as ready for review August 7, 2024 15:46
@milldr milldr requested review from a team as code owners August 7, 2024 15:46
@milldr milldr mentioned this pull request Aug 7, 2024
Merged
@milldr @osterman
Apply suggestions from code review
cfac529 
Co-authored-by: Erik Osterman (CEO @ Cloud Posse) <[email protected]>
osterman
osterman previously approved these changes Aug 7, 2024
View reviewed changes
@milldr milldr merged commit fec5106 into main Aug 7, 2024
4 checks passed
@milldr milldr deleted the DEV-2453/admonitions branch August 7, 2024 18:04
goruha pushed a commit to cloudposse-terraform-components/aws-account that referenced this pull request Nov 27, 2024
@milldr @osterman
Replace Admonition Style (cloudposse/terraform-aws-components#1092)
0408bd5 
Co-authored-by: Erik Osterman (CEO @ Cloud Posse) <[email protected]>
goruha pushed a commit to cloudposse-terraform-components/aws-auth0-tenant that referenced this pull request Nov 27, 2024
@milldr @osterman
Replace Admonition Style (cloudposse/terraform-aws-components#1092)
5711af4 
Co-authored-by: Erik Osterman (CEO @ Cloud Posse) <[email protected]>
goruha pushed a commit to cloudposse-terraform-components/aws-config that referenced this pull request Nov 27, 2024
@milldr @osterman
Replace Admonition Style (cloudposse/terraform-aws-components#1092)
212fdf4 
Co-authored-by: Erik Osterman (CEO @ Cloud Posse) <[email protected]>
goruha pushed a commit to cloudposse-terraform-components/aws-identity-center that referenced this pull request Nov 27, 2024
@milldr @osterman
Replace Admonition Style (cloudposse/terraform-aws-components#1092)
50b3b67 
Co-authored-by: Erik Osterman (CEO @ Cloud Posse) <[email protected]>
goruha pushed a commit to cloudposse-terraform-components/aws-dns-primary that referenced this pull request Nov 27, 2024
@milldr @osterman
Replace Admonition Style (cloudposse/terraform-aws-components#1092)
22e5549 
Co-authored-by: Erik Osterman (CEO @ Cloud Posse) <[email protected]>
goruha pushed a commit to cloudposse-terraform-components/aws-ecr that referenced this pull request Nov 27, 2024
@milldr @osterman
Replace Admonition Style (cloudposse/terraform-aws-components#1092)
a25bb4a 
Co-authored-by: Erik Osterman (CEO @ Cloud Posse) <[email protected]>
goruha pushed a commit to cloudposse-terraform-components/aws-eks-actions-runner-controller that referenced this pull request Nov 27, 2024
@milldr @osterman
Replace Admonition Style (cloudposse/terraform-aws-components#1092)
f68021e 
Co-authored-by: Erik Osterman (CEO @ Cloud Posse) <[email protected]>
goruha pushed a commit to cloudposse-terraform-components/aws-eks-cluster that referenced this pull request Nov 27, 2024
@milldr @osterman
Replace Admonition Style (cloudposse/terraform-aws-components#1092)
149f405 
Co-authored-by: Erik Osterman (CEO @ Cloud Posse) <[email protected]>
goruha pushed a commit to cloudposse-terraform-components/aws-eks-datadog-agent that referenced this pull request Nov 27, 2024
@milldr @osterman
Replace Admonition Style (cloudposse/terraform-aws-components#1092)
744e0a3 
Co-authored-by: Erik Osterman (CEO @ Cloud Posse) <[email protected]>
goruha pushed a commit to cloudposse-terraform-components/aws-eks-karpenter-controller that referenced this pull request Nov 27, 2024
@milldr @osterman
Replace Admonition Style (cloudposse/terraform-aws-components#1092)
44cb208 
Co-authored-by: Erik Osterman (CEO @ Cloud Posse) <[email protected]>
goruha pushed a commit to cloudposse-terraform-components/aws-github-runners that referenced this pull request Nov 27, 2024
@milldr @osterman
Replace Admonition Style (cloudposse/terraform-aws-components#1092)
61f55cf 
Co-authored-by: Erik Osterman (CEO @ Cloud Posse) <[email protected]>
goruha pushed a commit to cloudposse-terraform-components/aws-network-firewall that referenced this pull request Nov 27, 2024
@milldr @osterman
Replace Admonition Style (cloudposse/terraform-aws-components#1092)
e16f133 
Co-authored-by: Erik Osterman (CEO @ Cloud Posse) <[email protected]>
goruha pushed a commit to cloudposse-terraform-components/aws-tfstate-backend that referenced this pull request Nov 27, 2024
@milldr @osterman
Replace Admonition Style (cloudposse/terraform-aws-components#1092)
2bb7e91 
Co-authored-by: Erik Osterman (CEO @ Cloud Posse) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osterman osterman osterman approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation no-release Do not create a new release (wait for additional code changes)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@milldr @osterman