Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Fix usage snippet (missing source attribute) #25

Merged
merged 2 commits into from
Oct 22, 2021
Merged

Docs: Fix usage snippet (missing source attribute) #25

merged 2 commits into from
Oct 22, 2021

Conversation

korenyoni
Copy link
Member

what

  • Fix usage snippet (missing source attribute)
  • Fix module block name in usage snippet (does not match module name)

why

  • The usage snippet is incorrect (missing source attribute and does not match module name)

references

  • N/A

@korenyoni korenyoni requested review from a team as code owners October 22, 2021 14:02
@korenyoni korenyoni requested review from jhosteny and brcnblc October 22, 2021 14:02
@korenyoni korenyoni added the patch A minor, backward compatible change label Oct 22, 2021
@korenyoni korenyoni requested a review from nitrocode October 22, 2021 14:03
@korenyoni
Copy link
Member Author

/test all

@nitrocode nitrocode added no-release Do not create a new release (wait for additional code changes) and removed patch A minor, backward compatible change labels Oct 22, 2021
@korenyoni korenyoni merged commit 51de1bd into master Oct 22, 2021
@korenyoni korenyoni deleted the docs/fix-usage-snippet branch October 22, 2021 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitrocode nitrocode nitrocode approved these changes

@jhosteny jhosteny Awaiting requested review from jhosteny jhosteny was automatically assigned from cloudposse/contributors

@brcnblc brcnblc Awaiting requested review from brcnblc brcnblc was automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
no-release Do not create a new release (wait for additional code changes)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@korenyoni @nitrocode @cloudpossebot