Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Make IAM Role Optional #24

Merged
merged 4 commits into from
Oct 21, 2021
Merged

Feat: Make IAM Role Optional #24

merged 4 commits into from
Oct 21, 2021

Conversation

korenyoni
Copy link
Member

what

  • Make IAM role conditional on feature flag.
  • Run make github/init.
  • Fix unintentional nested array in stream_arns output.
  • Fix usage snippet such that it conforms with other modules.

why

  • Not all CloudWatch Logs log group use cases require an IAM role meant for assumption by an EC2 instance. The IAM role should be conditional.
  • Running make github/init updates GHA workflow-related files.
  • Running make github/init updates context.tf to the latest distribution from null-label, which now has new features such as the tenant label.

references

@korenyoni
Run 'make github/init'; fix unintentional nested array in stream_arns…
adfffd4 
… output; fix usage snippet such that it conforms with other modules; make IAM role conditional on feature flag.
@korenyoni korenyoni added the enhancement New feature or request label Oct 21, 2021
@korenyoni korenyoni requested review from a team as code owners October 21, 2021 22:48
@korenyoni korenyoni requested review from bradj and srhopkins October 21, 2021 22:48
@korenyoni
Copy link
Member Author

/test all

@korenyoni korenyoni requested a review from aknysh October 21, 2021 22:52
@korenyoni
Copy link
Member Author

/test all

@korenyoni korenyoni merged commit 0d6ed23 into master Oct 21, 2021
@korenyoni korenyoni deleted the feat/optional-iam-role branch October 21, 2021 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh approved these changes

@bradj bradj Awaiting requested review from bradj bradj was automatically assigned from cloudposse/contributors

@srhopkins srhopkins Awaiting requested review from srhopkins srhopkins was automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@korenyoni @aknysh @cloudpossebot