Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamically generate cors rules, fixes #22 #84

Merged
merged 3 commits into from
Jun 23, 2020
Merged

Dynamically generate cors rules, fixes #22 #84

merged 3 commits into from
Jun 23, 2020

Conversation

Makeshift
Copy link

@Makeshift Makeshift commented Jun 5, 2020

what

  • We now dynamically generate the cors rules block so we correctly create a block for each alias/allowed origin.

why

  • Cors origins don't work without these changes
  • I believe this change makes them work as intended in the original module

references

@Makeshift Makeshift changed the title Dynamically generate cors rules, fixes Dynamically generate cors rules, fixes #22 Jun 5, 2020
@Makeshift Makeshift marked this pull request as ready for review June 5, 2020 09:25
@osterman
Copy link
Member

/test all

@osterman
Copy link
Member

Unfortunately tests are failing b/c someone's tests have created the bucket and not deleted it. We'll need to fix the tests in this module before merging by generating the bucket name.

If you are able to incorporate these changes, that would be much appreciated. See example here: https://github.com/cloudposse/terraform-aws-alb/pull/42/files

@Gowiem Gowiem requested a review from a team as a code owner June 23, 2020 18:59
@Gowiem Gowiem requested review from Gowiem and aknysh and removed request for a team June 23, 2020 18:59
@Gowiem
Copy link
Member

Gowiem commented Jun 23, 2020

/test all

@Gowiem Gowiem merged commit e84f466 into cloudposse:master Jun 23, 2020
@Gowiem
Copy link
Member

Gowiem commented Jun 23, 2020

@Makeshift Thanks for the contribution! Released as 0.24.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in configuration of allowed origins for S3 bucket
3 participants