Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update bucket logging module version #82

Merged
merged 2 commits into from
Jun 27, 2020
Merged

Update bucket logging module version #82

merged 2 commits into from
Jun 27, 2020

Conversation

okgolove
Copy link
Contributor

@okgolove okgolove commented Jun 1, 2020

Update to latest label module to support the environment attribute

what

  • Add compatibility with the latest label module's version

why

  • s3 bucket module has the same name in different environment

references

@Gowiem
Copy link
Member

Gowiem commented Jun 23, 2020

/test all

Gowiem
Gowiem previously approved these changes Jun 23, 2020
View reviewed changes
Copy link
Member

@Gowiem Gowiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid 👍

@okgolove
Copy link
Contributor Author

Is it ok tests failed?

@Gowiem
Copy link
Member

Gowiem commented Jun 23, 2020

@okgolove I'd like to ensure they pass. Once #86 merges (should be later today) then we'll be good to go and I'll get this shipped. Sorry for the wait!

@Gowiem
Copy link
Member

Gowiem commented Jun 23, 2020

@okgolove Sorry to do it to ya, but it looks like there are some merge conflicts. Mind fixing and we'll get this merged?

@okgolove
Update bucket logging module version
244508d 
Update to latest label module to support the environment attribute
@okgolove okgolove requested a review from a team as a code owner June 27, 2020 15:32
@okgolove okgolove requested review from Gowiem and aknysh and removed request for a team June 27, 2020 15:32
@okgolove
Copy link
Contributor Author

@Gowiem it seems I shouldn't run make readme. :)
I delete all changes related to README's.

@Gowiem
Copy link
Member

Gowiem commented Jun 27, 2020

/rebuild-readme

@Gowiem
Copy link
Member

Gowiem commented Jun 27, 2020

/test all

Gowiem
Gowiem approved these changes Jun 27, 2020
View reviewed changes
Copy link
Member

@Gowiem Gowiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @okgolove -- Thanks for the merge conflict fix!

@Gowiem Gowiem merged commit f7907f3 into cloudposse:master Jun 27, 2020
@Gowiem
Copy link
Member

Gowiem commented Jun 27, 2020

@okgolove Thanks for the contribution! Released as 0.25.0.

@okgolove okgolove deleted the feature/update-logging-and-label branch June 29, 2020 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gowiem Gowiem Gowiem approved these changes

@aknysh aknysh Awaiting requested review from aknysh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@okgolove @Gowiem @actions-bot