Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: added ability to set the attributes block_public_acls and ig… #323

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feature: added ability to set the attributes block_public_acls and ig… #323

wants to merge 1 commit into from

Conversation

Faris96Hub
Copy link

…nore_public_acls for the origin bucket

what

  • added optional variables block_public_acls and ignore_public_acls to be able to set those attributes in the resource "aws_s3_bucket_public_access_block". The default is set to true to match the current module config.

why

  • Needed to be able to make the origin bucket optionally publicly accessable

references

@Faris96Hub Faris96Hub requested review from a team as code owners September 12, 2024 10:15
@mergify mergify bot added the triage Needs triage label Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gowiem Gowiem Awaiting requested review from Gowiem Gowiem is a code owner automatically assigned from cloudposse/contributors

@RoseSecurity RoseSecurity Awaiting requested review from RoseSecurity RoseSecurity is a code owner automatically assigned from cloudposse/contributors

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
triage Needs triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Faris96Hub