Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support AWS Provider V5 #284

Merged
merged 61 commits into from
Jul 25, 2023
Merged

Support AWS Provider V5 #284

merged 61 commits into from
Jul 25, 2023

Conversation

max-lobur
Copy link
Contributor

what

Support AWS Provider V5
Linter fixes

why

Maintenance

references

https://github.com/hashicorp/terraform-provider-aws/releases/tag/v5.0.0

@max-lobur max-lobur added the no-release Do not create a new release (wait for additional code changes) label Jun 9, 2023
@max-lobur max-lobur requested review from a team as code owners June 9, 2023 17:06
@max-lobur max-lobur added major Breaking changes (or first stable release) and removed no-release Do not create a new release (wait for additional code changes) labels Jun 9, 2023
@max-lobur
Copy link
Contributor Author

/terratest

@max-lobur
Copy link
Contributor Author

/terratest

main.tf Outdated Show resolved Hide resolved
examples/complete/s3-origins.tf Outdated Show resolved Hide resolved
examples/complete/s3-origins.tf Outdated Show resolved Hide resolved
@milldr
Copy link
Member

milldr commented Jul 22, 2023

/terratest

@milldr
Copy link
Member

milldr commented Jul 24, 2023

/terratest

@milldr
Copy link
Member

milldr commented Jul 24, 2023

/terratest

@milldr
Copy link
Member

milldr commented Jul 24, 2023

/terratest

@milldr
Copy link
Member

milldr commented Jul 24, 2023

/terratest

@milldr
Copy link
Member

milldr commented Jul 24, 2023

/terratest

@milldr
Copy link
Member

milldr commented Jul 25, 2023

/terratest

@milldr
Copy link
Member

milldr commented Jul 25, 2023

/terratest

@milldr
Copy link
Member

milldr commented Jul 25, 2023

/terratest

@milldr
Copy link
Member

milldr commented Jul 25, 2023

/terratest

@max-lobur max-lobur merged commit b87a8be into main Jul 25, 2023
9 checks passed
@max-lobur max-lobur deleted the aws_v5 branch July 25, 2023 14:21
abeluck pushed a commit to abeluck/terraform-aws-cloudfront-s3-cdn that referenced this pull request Aug 11, 2023
* Support AWS Provider V5

* Update versions.tf

* Update versions.tf

* Update versions.tf

* Support AWS Provider V5

* bump provider

* Support AWS Provider V5

* Support AWS Provider V5

* Support AWS Provider V5

* Support AWS Provider V5

* upd

* upd

* upd

* upd

* upd

* upd

* upd

* upd

* upd

* upd

* upd

* upd

* upd

* Add policy

* use ACL for logging s3-bucket access

* make readme

* Removed unused locals, use updated bucket acl pattern, enable logging by local

* allow public policy for test bucket

* tf fmt

* set BucketOwnerEnforced

* set acl with string, not grant

* set logs ownership to ObjectWriter

* set s3_object_ownership for test buckets

* set logs bucket to BucketOwnerPreferred

* Set bucket-owner-full-control

* reset to grant

* Update main.tf

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* set log-delivery-write for test bucekts

* set ownership on test bucket

* set BucketOwnerPreferred with grant list for test buckets

* reset tests, set ownership to BucketOwnerPreferred

* setting s3_object_ownership

* dependency for bucket settings before cdn

* Update examples/complete/main.tf

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* dependency for tweaks

* added more wait ons for bucket settings

* added more wait ons for bucket settings

* set ownership on test bucket, set acl null of s3

* set BucketOwnerEnforced

* set grants

* set grants

* Set policy after bucket settings

* Set block_origin_public_access_enabled

* revert s3-origins test

* set BucketOwnerEnforced

* sleep for eventual consistency

* Set acl for s3-origin tests

* replace s3-website module with s3-bucket for tests

* corrected bucket name input

* corrected bucket name input

* bridgecrew issues resolved

---------

Co-authored-by: milldr <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor New features that do not break anything
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants