Support source_zip as source for Lambda@Edge submodule
#262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zdmytriv
requested review from
jamengual and
joe-niland
and removed request for
a team
|
/test all |
|
/test all |
|
/test all |
|
/test all |
added 2 commits
March 21, 2023 17:37
|
/test all |
|
/test all |
|
/test all |
zdmytriv
changed the title
source_zip as source for Lambda@Edge submodule
max-lobur
approved these changes
Mar 22, 2023
abeluck
pushed a commit
to abeluck/terraform-aws-cloudfront-s3-cdn
that referenced
this pull request
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Added support
source_zipoption for lambda@edge functions.why
There are cases when we need to send the archive as a source for Lambda@Edge. For example, include
node_modulesfor node js projects.So at the moment, this module supports 3 types of sources for Cloudfront Lambda@Edge:
source- just a string with source code that is going to be saved to a file and archived by this modulesource_dir- path to the directory that contains a few files and/or subdirectories that are going to be archived by this modulesource_zip- path to a single zip file. This is useful when Lambda@Edge has a lot of dependencies for example in the case of NodeJS -node_modulesdirectorySee
examples/completefor usage examples.references