Support AWS Provider V5 #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-lobur
added
the
no-release
|
/terratest |
![bridgecrew[bot]](https://avatars.githubusercontent.com/in/52968?s=60&v=4){kind=small}
max-lobur
removed
the
no-release
|
/terratest |
|
/terratest |
|
This will need the same work: cloudposse/terraform-aws-ecs-codepipeline#112 (comment) |
|
Looks like tests passed 🚀 |
|
Weird, was supposed to fail with v5. |
|
|
milldr
approved these changes
Nov 15, 2023
|
That still didn't work, the error is the same I expected. Our CI started to show false positives on PRs, but gate fails , so no release. I will investigate later |
nathanluskey
pushed a commit
to Curia-ai/terraform-aws-cicd
that referenced
this pull request
Jan 18, 2024
This reverts commit 921a2cb.
nathanluskey
added a commit
to Curia-ai/terraform-aws-cicd
that referenced
this pull request
Jan 18, 2024
* feat: add codestar_connection_arn for source of codepipeline * chore: formatting * Revert "Support AWS Provider V5 (cloudposse#115)" This reverts commit 921a2cb.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Support AWS Provider V5
Major release because of the dependencies pinning aws provider v5
Linter fixes
why
Maintenance
references
https://github.com/hashicorp/terraform-provider-aws/releases/tag/v5.0.0