Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add zone id #49

Merged
merged 6 commits into from
Aug 18, 2021
Merged

Add zone id #49

merged 6 commits into from
Aug 18, 2021

Conversation

nitrocode
Copy link
Member

@nitrocode nitrocode commented Aug 18, 2021 •
edited
Loading

what

  • Add zone_id

why

  • Create an implicit link between zone creation and acm creation
  • This gives the consumer the option to use domain name, zone name, or zone id to use the data source to retrieve the existing hosted zone

references

@nitrocode
Copy link
Member Author

/test all

@nitrocode
Copy link
Member Author

/test all

@nitrocode nitrocode marked this pull request as ready for review August 18, 2021 05:51
@nitrocode nitrocode requested review from a team as code owners August 18, 2021 05:51
@nitrocode nitrocode mentioned this pull request Aug 18, 2021
Closed
@nitrocode nitrocode merged commit 27664c5 into master Aug 18, 2021
@nitrocode nitrocode deleted the zone_id branch August 18, 2021 18:15
@nitrocode nitrocode mentioned this pull request Aug 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamengual jamengual jamengual approved these changes

@dotCipher dotCipher Awaiting requested review from dotCipher

@Benbentwo Benbentwo Awaiting requested review from Benbentwo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@nitrocode @jamengual @cloudpossebot