nomad: new package #329
Merged
nomad: new package #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osterman
previously requested changes
Feb 8, 2020
There was a problem hiding this comment.
Please update to use macro so we can reduce copypasta.
https://github.com/cloudposse/packages/blob/master/tasks/Makefile.package#L74-L82
|
/codefresh run apk |
maximmi
suggested changes
Feb 20, 2020
| @@ -0,0 +1,14 @@ | |||
| ## Package - nomad | |||
There was a problem hiding this comment.
Suggested change
| ## Package - nomad | |
| ## Package - nomad | |
| export PACKAGE_ENABLED = false |
@zloeber please add this line at the top of Makefile to skip packaging due to apk build fail issue. See build logs here: https://g.codefresh.io/build/5e4ec06cc5b02577f39bc133?step=apk_build_3_11&tab=output
and related root of the problem here: hashicorp/nomad#5535
maximmi
reviewed
Feb 20, 2020
vendor/nomad/VERSION
Outdated
| @@ -0,0 +1 @@ | |||
| 0.10.2 | |||
There was a problem hiding this comment.
Suggested change
| 0.10.2 | |
| 0.10.4 |
Newer version is available
|
/codefresh run apk |
maximmi
approved these changes
Feb 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what