Added terraform output to summary #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osterman
reviewed
Jan 24, 2024
osterman
reviewed
Jan 24, 2024
action.yml
Outdated
| @@ -289,7 +289,10 @@ runs: | |||
| --output "${{ github.workspace }}/atmos-apply-summary.md" \ | |||
| --log-level $([[ "${{ inputs.debug }}" == "true" ]] && echo "DEBUG" || echo "INFO") \ | |||
| apply -- terraform apply ${{ steps.vars.outputs.plan_file }} || EXIT_CODE=$? | |||
|
|
|||
|
|
|||
| TERRAFORM_OUTPUTS=$(terraform output --json | jq -Mr 'to_entries | map(["|", .key, "|", if .value.sensitive then "\\<sensitive\\>" else .value.value end, "|"] | join(" ")) | if length > 0 then ["| name | value |", "|----|----|"] + . else ["No outputs"] end | join("\n")') | |||
There was a problem hiding this comment.
Suggested change
| TERRAFORM_OUTPUTS=$(terraform output --json | jq -Mr 'to_entries | map(["|", .key, "|", if .value.sensitive then "\\<sensitive\\>" else .value.value end, "|"] | join(" ")) | if length > 0 then ["| name | value |", "|----|----|"] + . else ["No outputs"] end | join("\n")') | |
| TERRAFORM_OUTPUTS=$(terraform output --json | jq -Mr 'to_entries | map(["|", .key, "|", if .value.sensitive then "" else .value.value end, "|"] | join(" ")) | if length > 0 then ["| name | value |", "|:----|:----|"] + . else ["No outputs"] end | join("\n")') |
There was a problem hiding this comment.
my preference would be to encapsulate single-line outputs with inline code and multiline values with a
code block
As outputs are often maps, which would render better that way.
Also, I have concerns of the mileage we'll get using JQ for formatting. But if we can get what we need... that's okay.
There was a problem hiding this comment.
| name | value |
|---|---|
| result | WGAQulCR148 |
| sensitive_value |  |
Or with HTML:
| output | value |
|---|---|
| result | WGAQulCR148 |
| sensitive_value | |
| test |
{
"matchStringsStrategy": "combination",
"datasourceTemplate": "helm",
"versioningTemplate": "cargo",
"rangeStrategy": "bump"
}
|
osterman
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
apply