Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Derived Components #6

Merged
merged 23 commits into from
Jul 26, 2023
Merged

Support Derived Components #6

merged 23 commits into from
Jul 26, 2023

Conversation

milldr
Copy link
Member

@milldr milldr commented Jul 10, 2023 •
edited
Loading

what

  • Add support for derived components with multiple definitions of a setting

why

  • Fix broken action. If a component has the setting defined at multiple levels (defaults, base component, derived component), this action returns a list, not the last value.
  • Return the last value given

references

dudymas
dudymas reviewed Jul 26, 2023
View reviewed changes
action.yml Show resolved Hide resolved
dudymas
dudymas approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@dudymas dudymas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@milldr milldr merged commit 01c6cdb into main Jul 26, 2023
5 checks passed
@milldr milldr deleted the return-last branch July 26, 2023 01:44
This was referenced Jul 26, 2023
Merged
Merged
@milldr milldr mentioned this pull request Aug 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dudymas dudymas dudymas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@milldr @dudymas