Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get any info from atmos describe component #17

Merged
merged 10 commits into from
Dec 13, 2023
Merged

Conversation

goruha
Copy link
Member

@goruha goruha commented Dec 4, 2023

what

  • Remove restriction to settings section.

Why

  • To reuse this action for fetching component_info.component_path settings

Migrating from v0 to v1

Starting from v1 the action is no longer restricted to retrieving the component config from only the settings section..
If you want the same behavior in v1 as inv0, you should add the settings prefix to the value of the settings-path variable.

  - name: Get Atmos Setting for Secret ARN
    uses: cloudposse/github-action-atmos-get-setting@v1
    id: example
    with:
      component: foo
      stack: core-ue1-dev
      settings-path: settings.secrets-arn  

same behaviour as

  - name: Get Atmos Setting for Secret ARN
    uses: cloudposse/github-action-atmos-get-setting@v0
    id: example
    with:
      component: foo
      stack: core-ue1-dev
      settings-path: secrets-arn  

@goruha goruha added the major Breaking changes (or first stable release) label Dec 4, 2023
milldr
milldr previously approved these changes Dec 8, 2023
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.yaml Outdated Show resolved Hide resolved
README.yaml Outdated Show resolved Hide resolved
dudymas
dudymas previously approved these changes Dec 11, 2023
Copy link
Contributor

@dudymas dudymas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but could use a couple updates if you agree with my nitpicking

README.md Outdated Show resolved Hide resolved
README.yaml Show resolved Hide resolved
README.yaml Outdated Show resolved Hide resolved
goruha and others added 3 commits December 12, 2023 03:43
Co-authored-by: Jeremy White <[email protected]>
Co-authored-by: Erik Osterman (CEO @ Cloud Posse) <[email protected]>
@goruha goruha merged commit faa6886 into main Dec 13, 2023
5 checks passed
@goruha goruha deleted the retrive-general-settings branch December 13, 2023 00:11
@goruha goruha restored the retrive-general-settings branch December 13, 2023 00:16
@goruha goruha deleted the retrive-general-settings branch January 31, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major Breaking changes (or first stable release)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants