generated from cloudposse-github-actions/composite-template
-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get any info from atmos describe component #17
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milldr
previously approved these changes
Dec 8, 2023
osterman
reviewed
Dec 9, 2023
dudymas
reviewed
Dec 11, 2023
dudymas
reviewed
Dec 11, 2023
dudymas
previously approved these changes
Dec 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but could use a couple updates if you agree with my nitpicking
osterman
reviewed
Dec 11, 2023
osterman
reviewed
Dec 11, 2023
osterman
reviewed
Dec 11, 2023
Co-authored-by: Jeremy White <[email protected]> Co-authored-by: Erik Osterman (CEO @ Cloud Posse) <[email protected]>
osterman
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
settings
section.Why
component_info.component_path
settingsMigrating from
v0
tov1
Starting from
v1
the action is no longer restricted to retrieving the component config from only thesettings
section..If you want the same behavior in
v1
as inv0
, you should add thesettings
prefix to the value of thesettings-path
variable.same behaviour as