-
-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Docker rootless mode & fix file ownership in root mode #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nuru
added
bugfix
Change that restores intended behavior
enhancement
New feature or request
labels
Feb 15, 2022
By/Large, this works as expected and I'd approve this as-is. I would suggest adding something about |
nitrocode
approved these changes
Feb 17, 2022
aknysh
reviewed
Feb 17, 2022
@@ -3,6 +3,12 @@ | |||
# for a customer using the Cloud Posse Reference Architecture. | |||
# Use it as a basis for your own customizations. | |||
# | |||
# Note that Geodesic supports runtime customizations that | |||
# do not require a custome Dockerfile. See: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
# do not require a custome Dockerfile. See: | |
# do not require a custom Dockerfile. See: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what && why
$HOME/.local/bin
(per XDG recommendation) if/usr/local/bin
is not writable. Supports preferred solution for Files Written to Mounted Linux Home Directory Owned by Root User #594, which is to have users run Docker in "rootless" mode.docker
daemon as root.prompt.sh
and Prompt Hooks Not Being Found #766notes
This release introduces a new customization:
When Geodesic is launched by a shell where
$GEODESIC_HOST_BINDFS_ENABLED == true
it will configure/localhost
so that files created byroot
inside Geodesic will have their ownership mapped to the same user ID and group ID as on the host. This a solution for people experiencing #594 and ONLY them. If your present solution is not creating files on the host owned byroot
then option will likely cause new problems.Note further that this is a workaround and not the desired solution. Our recommendation is that you resolve the underlying issue by running Docker in "rootless" mode. This is much more secure and avoids the issue causing problems in the first place.