Feat: Add direnv allow persistence between sessions
#762
Conversation
korenyoni
changed the title
direnv allow persistence between sessions
| local geodesic_folder="$(dirname "$geodesic_default_env_file")" | ||
| local geodesic_direnv_folder=${geodesic_folder}/direnv | ||
| mkdir -p $geodesic_direnv_folder | ||
| DOCKER_ARGS+=(--volume="$geodesic_direnv_folder:/usr/share/xdg_data_home/direnv") |
There was a problem hiding this comment.
geodesic/os/alpine/Dockerfile.alpine
Line 62 in ac1d453
| DOCKER_ARGS+=(--volume="$geodesic_direnv_folder:/usr/share/xdg_data_home/direnv") | |
| DOCKER_ARGS+=(--volume="$geodesic_direnv_folder:$XDG_DATA_HOME/direnv") |
| @@ -8,7 +8,7 @@ unset BASH_ENV | |||
| export DIRENV_LOG_FORMAT= | |||
|
|
|||
| # Allow current working directory (if we have permission) | |||
| if [ -f .envrc ] && [ -w /etc/direnv/allow ]; then | |||
| if [ -f .envrc ] && [ -d /usr/share/xdg_data_home/direnv ] && [ -w /usr/share/xdg_data_home/direnv ]; then | |||
There was a problem hiding this comment.
| if [ -f .envrc ] && [ -d /usr/share/xdg_data_home/direnv ] && [ -w /usr/share/xdg_data_home/direnv ]; then | |
| if [ -f .envrc ] && [ -d "${XDG_DATA_HOME}/direnv" ] && [ -w "${XDG_DATA_HOME}/direnv" ]; then |
geodesic/os/alpine/Dockerfile.alpine
Line 62 in ac1d453
|
Edited PR description to match our pull request format. |
|
My problem is solved if I set How should this be documented? Had I know this, none of this would be necesary |
I think we'll have to make a new place for it. At the very least a subsection in I've created #768 |
|
I can document this, as I want to add some customization docs when I submit my fix for #594 (which I need some more consensus before I submit) |
There was a problem hiding this comment.
@drmikecrowe Thank you for this submission, and sorry for the confusion and the extra effort you had to go to find the solution.
We are not going to approve this PR for a bunch of reasons. Besides not being needed, if we wanted to persist the data on the host, we would want to have the option to do it on a per-image basis, for people that use more than one Geodesic-based Docker image. This would get pretty complicated, and it does not seem there is enough demand to justify the effort.
As for documentation (cc @korenyoni and #768), we currently document (to some extent) build-time configurations option in the Docker files. Specifically:
Granted, it would be better to have the options more fully documented, and consolidated in one place, and easier to find. We will work on that: #768
For those wondering about runtime configuration, while we do have good documentation on how to set runtime options, we unfortunately do not at the moment have much documentation on what the runtime options are. Your best resource for that at present is to review the code in the profile.d directory and look for all uppercase environment variables. We try to make them reasonably self-documenting, but of course we acknowledge we could do a lot better. We do try to document them pretty well when we first introduce them, so you may find better information in the release notes. See, for example "New options for customizing command line prompt appearance" in the Release Notes for v0.149.0.
what
direnv allowbetween sessions by dedicating$HOME/.geodesic/direnvto/usr/share/xdg_data_home/direnvin the containerwhy
direnv allowis not persisted between sessions