Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shfmt #305

Merged
merged 5 commits into from
Nov 1, 2018
Merged

Add shfmt #305

merged 5 commits into from
Nov 1, 2018

Conversation

vadim-gleif
Copy link
Contributor

what

  • Use shfmt to format all shell scripts

why

@vadim-gleif vadim-gleif requested a review from osterman October 28, 2018 20:43
Copy link
Member

@osterman osterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add fmt check to Travis yml so we error if code not formatted

Now fmt fails when some files not formatted
Fix wrapper and bootstrap - fmt can't process gomplate
@vadim-gleif vadim-gleif force-pushed the sh-targets branch 8 times, most recently from edd3b36 to 76f0a24 Compare October 31, 2018 17:35
@osterman osterman merged commit 1b88c8d into master Nov 1, 2018
@osterman osterman deleted the sh-targets branch November 1, 2018 04:35
leb4r pushed a commit that referenced this pull request Jan 25, 2022
* Rebuilt README.md (#270)

* Automatically update README nightly (#268)

* Automatically update README nightly

* fix triggers

* add name

* fix syntax

* add labels

* Fix example (#272)

* Update README.md (#273)

* Kind (#266)

* update: add kind

* update: minor pathing fixes to makefile inclusion documentation for a functional example

* update: Additional notes for adding new packages, minor wording fix for description of fetch package, update of readme

* Update README.yaml

Co-Authored-By: Erik Osterman <[email protected]>

* Update README.md

Co-Authored-By: Erik Osterman <[email protected]>

* update: minor readme fixes

* Update README.yaml

Co-Authored-By: Erik Osterman <[email protected]>

* Update README.yaml

Co-Authored-By: Erik Osterman <[email protected]>

* Update README.md (#274)

* Automated Package Updates (#275)

* update packages

* Fix vendor packages after updates

* Restore Makefile

* fix tarball

* reset release

* Update actions (#276)

* Update actions

* refactor auto-lable

* remove dup

* Update README.md (#278)

* update packages (#279)

* Automated Package Updates (#280)

* update packages

* fix sops download url

* Automated Package Updates (#281)

* update packages

* Fix pandoc url

* Rollback release

* update packages (#282)

* feature: kubectl plugin manager (krew) app (#286)

* [jx] add tool (#287)

* [jx] add tool

* fix: install as tarball, not binary

* [rancher] Add Package (#288)

* update packages (#285)

* Amtool (#271)

* update: addition of amtool

* update: addition of amtool

* update: amtool build fixes

* update: amtool build fixes

* update: amtool apk build

* fix: add amtool to auto-label

* fix: Makefile fix?

* fix: Makefile auto-label

* update: readme update

* update: auto-label space update

* Automated Package Updates (#289)

* update packages

* update packages

* update packages

* update packages (#290)

* popeye: add package

* argocd: Add package

* argocd: version update

* update: fix argocd apk build

* update: fix argocd apk build

Co-authored-by: Erik Osterman <[email protected]>
Co-authored-by: Cloud Posse Bot (CI/CD) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shell Formatting
2 participants