Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using cloudposse-specific repo to install hugo and htmltest #517

Merged
merged 8 commits into from
Feb 12, 2021

Conversation

dylanbannon
Copy link
Contributor

@dylanbannon dylanbannon commented Feb 10, 2021

what

  • The cloudposse/docs Docker image will now install hugo and htmltest from a CloudPosse-controlled repo ultimately being fed by cloudposse/packages.

why

  • This integrates cloudposse/docs with cloudposse/packages and removes any version maintenance burden on hugo and htmltest for the cloudposse/docs maintainers.

references

tasks/Makefile.hugo Outdated Show resolved Hide resolved
tasks/Makefile.hugo Outdated Show resolved Hide resolved
@dylanbannon dylanbannon requested a review from osterman February 10, 2021 22:34
@dylanbannon dylanbannon self-assigned this Feb 10, 2021
@dylanbannon dylanbannon added dependencies enhancement New feature or request labels Feb 10, 2021
@osterman
Copy link
Member

Please fix deprecations:

WARN 2021/02/10 22:28:50 Page.Hugo is deprecated and will be removed in a future release. Use the global hugo function.
WARN 2021/02/10 22:28:50 Page.URL is deprecated and will be removed in a future release. Use .Permalink or .RelPermalink. If what you want is the front matter URL value, use .Params.url
WARN 2021/02/10 22:28:51 Page.UniqueID is deprecated and will be removed in a future release. Use .File.UniqueID
WARN 2021/02/10 22:28:51 Page.Dir is deprecated and will be removed in a future release. Use .File.Dir
WARN 2021/02/10 22:28:51 .File.UniqueID on zero object. Wrap it in if or with: {{ with .File }}{{ .UniqueID }}{{ end }}
WARN 2021/02/10 22:28:51 .File.Dir on zero object. Wrap it in if or with: {{ with .File }}{{ .Dir }}{{ end }}

tasks/Makefile.hugo Outdated Show resolved Hide resolved
@dylanbannon
Copy link
Contributor Author

@osterman I was able to fix half of the deprecation warnings, but hugo's warnings weren't detailed enough for me to find the rest. I also tried turning on --verbose, but it didn't help.

@osterman
Copy link
Member

@dylanbannon share the details of which warnings you could not find

@dylanbannon
Copy link
Contributor Author

dylanbannon commented Feb 11, 2021

@osterman These three:

WARN 2021/02/11 00:19:48 Page.URL is deprecated and will be removed in a future release. Use .Permalink or .RelPermalink. If what you want is the front matter URL value, use .Params.url
WARN 2021/02/11 00:19:49 .File.UniqueID on zero object. Wrap it in if or with: {{ with .File }}{{ .UniqueID }}{{ end }}
WARN 2021/02/11 00:19:49 .File.Dir on zero object. Wrap it in if or with: {{ with .File }}{{ .Dir }}{{ end }}

I couldn't figure out how to get file information attached to the warnings.

@osterman
Copy link
Member

I suspect it's related to:
image

@osterman
Copy link
Member

I suspect Page.URL is related to:

{{ $currentPageUrl := .URL }}

Copy link
Member

@osterman osterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix remaining issues in new PR

@osterman osterman merged commit 2486c72 into master Feb 12, 2021
@osterman osterman deleted the move-dockerfile-to-packages branch February 12, 2021 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants