Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not clobber custom README *template* file #380

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Do not clobber custom README *template* file #380

merged 1 commit into from
Feb 9, 2024

Conversation

Nuru
Copy link
Contributor

@Nuru Nuru commented Feb 9, 2024

what

  • Do not clobber custom README template file

why

  • The default README template is now stored remotely, so we have to fetch it every time to ensure it is fresh (or else implement some more complicated test). However, if the make is not using the default README, we do not want to clobber the template it is using

references

@Nuru Nuru requested a review from osterman February 9, 2024 20:57
@Nuru Nuru requested review from a team as code owners February 9, 2024 20:57
@Nuru Nuru requested review from hans-d and florian0410 February 9, 2024 20:57
@github-actions github-actions bot requested a review from aknysh February 9, 2024 20:57
@github-actions github-actions bot requested a review from goruha February 9, 2024 20:57
@Nuru Nuru added the bugfix Change that restores intended behavior label Feb 9, 2024
@Nuru Nuru merged commit 784c6b3 into master Feb 9, 2024
14 checks passed
@Nuru Nuru deleted the custom-readme branch February 9, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osterman osterman osterman approved these changes

@hans-d hans-d Awaiting requested review from hans-d hans-d is a code owner automatically assigned from cloudposse/contributors

@florian0410 florian0410 Awaiting requested review from florian0410 florian0410 is a code owner automatically assigned from cloudposse/contributors

@aknysh aknysh Awaiting requested review from aknysh

@goruha goruha Awaiting requested review from goruha

Assignees

@Nuru Nuru

Labels
bugfix Change that restores intended behavior modules/readme
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nuru @osterman