Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix detection of github organization for README templates #374

Merged
merged 9 commits into from
Feb 1, 2024
Merged

Conversation

osterman
Copy link
Member

@osterman osterman commented Feb 1, 2024

what

  • Use the github_repo parameter in the README.yaml to determine the organization
  • Make git checkout safe for linters to use
  • Update uses of actions/checkout to v4

why

  • Use Organization's .github README.md.gotmpl #368 introduce the ability to have readme's sourced from various organizations
  • It did not take into account that the git remotes for forks will give the organization of the fork
  • It's better to use the README.yaml to determine the org, but this was not considered in the original implementation

references

hans-d
hans-d previously approved these changes Feb 1, 2024
goruha
goruha previously approved these changes Feb 1, 2024
@Nuru Nuru self-requested a review February 1, 2024 20:05
@Nuru Nuru merged commit 784518d into master Feb 1, 2024
14 of 15 checks passed
@Nuru Nuru deleted the fix-repo-org branch February 1, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants