Skip to content

v1.128.0
Compare
Choose a tag to compare
@cloudposse-releaser cloudposse-releaser released this 17 Dec 03:32
· 12 commits to refs/heads/main since this release
v1.128.0
2051592
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Learn about vigilant mode.
Replace `path.Join` with `filepath.Join` @samtholiya (#856)

what

  • Replaced all instances of path.Join with filepath.Join in the codebase
  • Updated imports to use the path/filepath package instead of path

why

  • Cross-platform compatibility: path.Join does not respect platform-specific path separators, causing potential issues on non-Unix systems (e.g. Windows)
  • Correct usage: filepath.Join is designed for working with filesystem paths, ensuring semantic correctness
  • Ensures the codebase adheres to Go best practices for handling file paths.

References

Mergify @osterman (#862)

what

  • Add mergify
  • Add tests

why

  • Mergify rules have some nice things like letting us know when PRs are stale or conflicted

Contributors

osterman and samtholiya
Assets 17
Loading