Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Separate Test Fixtures from Examples #918

Merged
merged 9 commits into from
Jan 6, 2025

Conversation

milldr
Copy link
Member

@milldr milldr commented Jan 6, 2025

what

  • Move examples/tests to tests/fixtures

why

  • Examples are intended to be just that, examples. We should not be including test usages with the examples.
  • As we expand our test coverage, we want someway to define many scenarios. By creating this pattern in tests/fixtures, we can define a scenario for each new use case.
    - Start with the simple migration of everything in a single complete scenario. Expand with new, smaller scope scenarios

references

Copy link

mergify bot commented Jan 6, 2025

Important

Cloud Posse Engineering Team Review Required

This pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes.

To expedite this process, reach out to us on Slack in the #pr-reviews channel.

@milldr milldr added minor New features that do not break anything and removed needs-cloudposse Needs Cloud Posse assistance triage Needs triage labels Jan 6, 2025
@mergify mergify bot added the needs-cloudposse Needs Cloud Posse assistance label Jan 6, 2025
@milldr milldr marked this pull request as ready for review January 6, 2025 21:37
@milldr milldr requested review from a team as code owners January 6, 2025 21:37
@milldr milldr merged commit bc0841c into main Jan 6, 2025
45 checks passed
@milldr milldr deleted the chore/DEV-2906_test-fixtures branch January 6, 2025 22:59
@mergify mergify bot removed the needs-cloudposse Needs Cloud Posse assistance label Jan 6, 2025
Copy link

github-actions bot commented Jan 7, 2025

These changes were released in v1.137.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor New features that do not break anything
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants