-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for helmfile version command #854
Add support for helmfile version command #854
Conversation
📝 WalkthroughWalkthroughThe changes introduce a new handling pathway for the "version" subcommand in the Changes
Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (2)
🔇 Additional comments (3)internal/exec/helmfile.go (1)
The implementation correctly handles the internal/exec/utils.go (2)
The changes correctly differentiate between the version command and other commands, ensuring that:
This implementation aligns well with the changes in
The global options handling variables are well-placed and clearly named, maintaining consistency with the existing codebase. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @samtholiya
These changes were released in v1.126.0. |
what
atmos helmfile version
commandCurrently:
After this pr:
why
We say atmos supports all native terraform commands, yet we do not support atmos helmfile version
references
issue: https://linear.app/cloudposse/issue/DEV-2844/atmos-helmfile-version-does-not-work
conversation: https://sweetops.slack.com/archives/D08447GN7JA/p1734006016227039?thread_ts=1734002589.248629&cid=D08447GN7JA
Summary by CodeRabbit