Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docker build ATMOS_VERSION support v* tags #671

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Fix docker build ATMOS_VERSION support v* tags #671

merged 1 commit into from
Aug 14, 2024

Conversation

goruha
Copy link
Member

@goruha goruha commented Aug 14, 2024

what

  • Remove v for ATMOS_VERSION on docker build

why

  • Cloudposse changed the tag template policy - now the tag is always prefixed with v.
    The tag passed as ATMOS_VERSION docker build argument

references

CleanShot 2024-08-14 at 19 58 32@2x

@goruha goruha requested review from a team as code owners August 14, 2024 18:02
@goruha goruha requested review from kevcube and RoseSecurity August 14, 2024 18:02
@goruha goruha merged commit 094872f into main Aug 14, 2024
21 checks passed
@goruha goruha deleted the fix-docker-build branch August 14, 2024 18:07
@github-actions GitHub Actions
Copy link

These changes were released in v1.86.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh approved these changes

@kevcube kevcube Awaiting requested review from kevcube kevcube was automatically assigned from cloudposse/contributors

@RoseSecurity RoseSecurity Awaiting requested review from RoseSecurity RoseSecurity was automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goruha @aknysh