-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update atmos vendor pull
and atmos validate stacks
commands. Add --include-dependents
flag to atmos describe affected
command
#616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aknysh
changed the title
Update
Update Jun 4, 2024
atmos validate stacks
command. Add --include-dependents
flag to atmos describe affected
commandatmos vendor pull
and atmos validate stacks
commands. Add --include-dependents
flag to atmos describe affected
command
osterman
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
atmos vendor pull
commandatmos validate stacks
command--include-dependents
flag toatmos describe affected
commandwhy
When executing
atmos vendor pull
, Atmos creates a temp directory to clone the remote repo into.Atmos uses
go-getter
to download the sources into the temp directory. When cloning from the root of a repo w/o using modules (sub-paths),go-getter
does the following:git init
For more details, refer to
Don't check for duplicate abstract components in the same stack from different stack manifests. Abstract components are never provisioned and serve as blueprints for real components. This is an update (follow up) to the previous PRs:
atmos validate stacks
andatmos describe affected
commands #608atmos validate stacks
command #611The
--include-dependents
flag allows including dependencies for the affected componentsIf the command-line flag
--include-dependents=true
is passed to theatmos describe affected
command, and there are other components that depend on the affected components in the stack, the command will include adependents
property (list) for each affected component. Thedependents
property is hierarchical - each component in the list will also contain adependents
property if that component has dependent components as well.For example, suppose that we have the following configuration for the Atmos components
component-1
,component-2
andcomponent-3
in the stackplat-ue2-dev
:In the above configuration,
component-3
depends oncomponent-2
, whereascomponent-2
depends oncomponent-1
.If all the components are affected (modified) in the current working branch, the
atmos describe affected --include-dependents=true
command will produce the following result:The
component-1
component does not depend on any other component, and therefore it has theincluded_in_dependents
attribute set tofalse
. Thecomponent-2
andcomponent-3
components depend on other components and are included in thedependents
property of the other components, and hence theincluded_in_dependents
attribute is set totrue
.When processing the above output, you might decide to not plan/apply the
component-2
andcomponent-3
components since they are in thedependents
property of thecomponent-1
component. Instead, you might just triggercomponent-1
and thencomponent-2
andcomponent-3
in the order of dependencies.